git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash-completion: don't add quoted space for ZSH (fix regression)

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 17, 2012, 23:42 UTC
Message-ID
<7v1uqxq4jm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAMP44s3GMGMD5Y9Z=Uu_e55_eZOG2zY76u8B=ORKsMx6yoXW5Q@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 9 quoted lines
>> As I was planning to queue Matthieu's patch as-is as a regression fix
>> before v1.7.9-rc2, I would appreciate if you can clarify this report a
>> bit. Do you mean with the patch more recent versions of zsh still does not
>> like the workaround and adds quoted space at the end?
>
> I am saying I am seeing the issue (or at least the same symptom) even
> before a31e626 with recent zsh versions. I will try a patched version
> of the script and a31e626, but I'm guessing the result would be the
> same.

OK, so the issue the patch addresses may not be a regression in the upcoming v1.7.9 we want to fix quickly, but if you tried the patch we might see improvements, or we might not see any improvements.

I'll hold onto Matthieu's patch for now, then. It would be nice to get this minor detail fixed before the release, though, as any fix would be of limited scope, affecting zsh users for which it is already broken.

Thanks.
Previous: Felipe ContrerasNext: Matthieu Moy
Message 16 of 21 in “Zsh completion regression”
  1. Stefan HallerJan 12, 2012
  2. Matthieu MoyJan 12, 2012
  3. SZEDER GáborJan 14, 2012
  4. Matthieu MoyJan 14, 2012
  5. SZEDER GáborJan 14, 2012
  6. bash-completion: don't add quoted space for ZSH (fix regression)Matthieu Moy, Jan 14, 2012
  7. Junio C HamanoJan 15, 2012
  8. Matthieu MoyJan 16, 2012
  9. Junio C HamanoJan 16, 2012
  10. Matthieu MoyJan 17, 2012
  11. Junio C HamanoJan 17, 2012
  12. Felipe ContrerasJan 17, 2012
  13. Felipe ContrerasJan 17, 2012
  14. Junio C HamanoJan 17, 2012
  15. Felipe ContrerasJan 17, 2012
  16. Junio C HamanoJan 17, 2012
  17. Matthieu MoyJan 18, 2012
  18. Felipe ContrerasJan 25, 2012
  19. Junio C HamanoJan 25, 2012
  20. Stefan HallerJan 14, 2012
  21. Stefan HallerJan 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.