Re: [PATCH/WIP v3 1/4] for-each-ref: extract helper functions out of grab_single_ref()

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 28, 2015, 20:13 UTC
Message-ID: <vpqr3q0o3yr.fsf@anie.imag.fr>
In-Reply-To: <1432835025-13291-1-git-send-email-karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> This is a preperatory patch for restructuring 'for-each-ref' and
> evntually moving most of it to 'ref-filter' to provide the

s/evntually/eventually/

The patch looks much nicer now.

Show 9 quoted lines

> -	int cnt;
> [...]
> +	REALLOC_ARRAY(cb->grab_array, cb->grab_cnt + 1);
> +	cb->grab_array[cb->grab_cnt++] = ref;
>  
> -	cnt = cb->grab_cnt;
> -	REALLOC_ARRAY(cb->grab_array, cnt + 1);
> -	cb->grab_array[cnt++] = ref;
> -	cb->grab_cnt = cnt;

This hunk is not advertized in the commit message, and I had to fight a bit to understand what it does with "we're extracting helper functions" in mind. It would have been much easier to review in a separate patch entitled "for-each-ref: simplify code" for example.

But I agree that your version is simpler indeed.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/