Re: [PATCH/WIP v3 1/4] for-each-ref: extract helper functions out of grab_single_ref()

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 28, 2015, 20:33 UTC
Message-ID: <55677B7D.3060209@gmail.com>
In-Reply-To: <vpqr3q0o3yr.fsf@anie.imag.fr>

On 05/29/2015 01:43 AM, Matthieu Moy wrote:

Show 6 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> This is a preperatory patch for restructuring 'for-each-ref' and
>> evntually moving most of it to 'ref-filter' to provide the
>
> s/evntually/eventually/

Noted.

Show 20 quoted lines

>
> The patch looks much nicer now.
>
>> -	int cnt;
>> [...]
>> +	REALLOC_ARRAY(cb->grab_array, cb->grab_cnt + 1);
>> +	cb->grab_array[cb->grab_cnt++] = ref;
>>
>> -	cnt = cb->grab_cnt;
>> -	REALLOC_ARRAY(cb->grab_array, cnt + 1);
>> -	cb->grab_array[cnt++] = ref;
>> -	cb->grab_cnt = cnt;
>
> This hunk is not advertized in the commit message, and I had to fight a
> bit to understand what it does with "we're extracting helper functions"
> in mind. It would have been much easier to review in a separate patch
> entitled "for-each-ref: simplify code" for example.
>
> But I agree that your version is simpler indeed.
>

Will put it in a separate patch. Thanks for the review.

-- 
Regards,
Karthik