Re: [PATCH] Expand ~ and ~user in core.excludesfile, commit.template

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Nov 17, 2009, 08:53 UTC
Message-ID: <vpqpr7hpm5b.fsf@bauges.imag.fr>
In-Reply-To: <20091117073426.GB4007@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On Mon, Nov 16, 2009 at 11:07:40AM +0100, Matthieu Moy wrote:
>
>> +	of files which are not meant to be tracked.  "~" and "~user"
>> +	are expanded to the user's home directory.  See
>>  	linkgit:gitignore[5].
>
> Reading this, it is not clear to me if:
>
>   1. "~" and "~user" are expanded to the home directory of "user", where
>      "user" is the user running git
>
> or
>
>   2. "~" is expanded to the home directory of the user running git, and
>      an arbitrary "~user" is expanded to that user's home directory.
>
> I would expect (2), since that is how everything else works.

Yes. "user" in the sentence is either the user running Git or the same string as "user" in "~user". I'm not against your proposal, but I'm afraid we're making the sentence uselessly heavy, since, as you say, this ~ and ~user convention is widely spread, and I hardly imagine someone interpreting the sentence as "if you say ~foo, it will expand to the home directory of bar".

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/