Re: [PATCH] Expand ~ and ~user in core.excludesfile, commit.template
- From
Andreas Schwab <schwab@linux-m68k.org>
- Date
- Nov 17, 2009, 21:20 UTC
- Message-ID
- <m2lji43l20.fsf@igel.home>
- In-Reply-To
- <20091117074930.GB11636@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 14 quoted lines
> On Tue, Nov 17, 2009 at 02:34:26AM -0500, Jeff King wrote: >> Maybe: >> >> A leading path component of "~user" is expanded to the home directory >> of "user"; "~" is expanded to the home directory of the user running >> git. >> >> would be more clear? > > Add "real" before "user running git" and you have my vote. Or maybe > using the effective user would be better, and the patch should use > geteuid() instead of getuid(), I don't know. ident.c uses getuid(), but > I'm wondering if that's what it should use (although it doesn't seem to > have been a problem to anyone)
"~" should just expand to the value of $HOME, like in the shell, independent of the real home directory of the real or effective user.
Andreas.
-- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."