Re: [PATCH] Expand ~ and ~user in core.excludesfile, commit.template
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2009, 22:16 UTC
- Message-ID
- <7v8we4er0t.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <m2lji43l20.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
Show 19 quoted lines
> Mike Hommey <mh@glandium.org> writes: > >> On Tue, Nov 17, 2009 at 02:34:26AM -0500, Jeff King wrote: >>> Maybe: >>> >>> A leading path component of "~user" is expanded to the home directory >>> of "user"; "~" is expanded to the home directory of the user running >>> git. >>> >>> would be more clear? >> >> Add "real" before "user running git" and you have my vote. Or maybe >> using the effective user would be better, and the patch should use >> geteuid() instead of getuid(), I don't know. ident.c uses getuid(), but >> I'm wondering if that's what it should use (although it doesn't seem to >> have been a problem to anyone) > > "~" should just expand to the value of $HOME, like in the shell, > independent of the real home directory of the real or effective user.
How should this interact with installations that run gitosis/gitlite that use shared account, giving user identity via the ssh key?
Note that the question is not "how would this...", but "how _should_ this...".