Re: [PATCH v2 03/10] ref-filter: support printing N lines from tag annotation

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 9, 2015, 13:07 UTC
Message-ID: <vpqpp417a4i.fsf@anie.imag.fr>
In-Reply-To: <1436437671-25600-3-git-send-email-karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> In 'tag.c' we can print N lines from the annotation of the tag
> using the '-n<num>' option.

Not only annotation of the tag, but also from the commit message for lightweight tags.

Show 8 quoted lines

> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -185,6 +185,10 @@ static enum contains_result contains(struct commit *candidate,
>  	return contains_test(candidate, want);
>  }
>  
> +/*
> + * Currently dupplicated in ref-filter, will eventually be removed as

dupplicated -> duplicated.

Show 16 quoted lines

> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -55,6 +55,7 @@ struct ref_filter {
>  	struct commit *merge_commit;
>  
>  	unsigned int with_commit_tag_algo : 1;
> +	unsigned int lines;
>  };
>  
>  struct ref_filter_cbdata {
> @@ -87,7 +88,7 @@ int verify_ref_format(const char *format);
>  /*  Sort the given ref_array as per the ref_sorting provided */
>  void ref_array_sort(struct ref_sorting *sort, struct ref_array *array);
>  /*  Print the ref using the given format and quote_style */
> -void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style);
> +void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style, unsigned int lines);

I would add "If lines > 0, prints the first 'lines' no of lines of the object pointed to" or so to the docstring.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/