git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 04/10] ref-filter: add support to sort by version

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 9, 2015, 13:29 UTC
Message-ID
<vpqfv4x792z.fsf@anie.imag.fr>
In-Reply-To
<1436437671-25600-4-git-send-email-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
> Add support to sort by version using the "v:refname" and
> "version:refname" option. This is achieved by using the
> 'version_cmp()' function as the comparing function for qsort.

You should elaborate on why you need this. Given the context, I can guess that you will need this to implement tag, but for example I first wondered why you needed both version: and v:, but I guess it comes from the fact that 'git tag --sort' can take version:refname or v:refname.

I think this deserves a test and documentation in for-each-ref.txt.

As-is, the code is a bit hard to understand. I first saw you were allowing

  git for-each-ref --format '%(version:refname)'

(which you are, but only as a side effect), and then understood that this was also allowing

  git for-each-ref --sort version:refname

A test would have shown me this immediately. Some hints in the commit message would clearly have helped too.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Karthik NayakNext: Karthik Nayak
Message 8 of 48 in “Port tag.c to use ref-filter APIs”
  1. 00/10 Port tag.c to use ref-filter APIsKarthik Nayak, Jul 9, 2015
  2. 01/10 ref-filter: add %(refname:shortalign=X) optionKarthik Nayak, Jul 9, 2015
  3. 02/10 ref-filter: add option to filter only tagsKarthik Nayak, Jul 9, 2015
  4. 03/10 ref-filter: support printing N lines from tag annotationKarthik Nayak, Jul 9, 2015
  5. Matthieu MoyJul 9, 2015
  6. Karthik NayakJul 10, 2015
  7. 04/10 ref-filter: add support to sort by versionKarthik Nayak, Jul 9, 2015
  8. Matthieu MoyJul 9, 2015
  9. Karthik NayakJul 10, 2015
  10. Karthik NayakJul 10, 2015
  11. Matthieu MoyJul 10, 2015
  12. Karthik NayakJul 11, 2015
  13. 05/10 ref-filter: add option to match literal patternKarthik Nayak, Jul 9, 2015
  14. Matthieu MoyJul 9, 2015
  15. Karthik NayakJul 10, 2015
  16. Junio C HamanoJul 10, 2015
  17. Karthik NayakJul 11, 2015
  18. Matthieu MoyJul 11, 2015
  19. Karthik NayakJul 11, 2015
  20. 06/10 Documentation/tag: remove double occurance of "<pattern>"Karthik Nayak, Jul 9, 2015
  21. Christian CouderJul 9, 2015
  22. Karthik NayakJul 9, 2015
  23. Junio C HamanoJul 10, 2015
  24. Karthik NayakJul 12, 2015
  25. 07/10 tag.c: use 'ref-filter' data structuresKarthik Nayak, Jul 9, 2015
  26. 08/10 tag.c: use 'ref-filter' APIsKarthik Nayak, Jul 9, 2015
  27. Matthieu MoyJul 9, 2015
  28. Karthik NayakJul 9, 2015
  29. Matthieu MoyJul 9, 2015
  30. Karthik NayakJul 10, 2015
  31. Matthieu MoyJul 9, 2015
  32. 08/10 tag.c: use 'ref-filter' APIsKarthik Nayak, Jul 9, 2015
  33. Duy NguyenJul 12, 2015
  34. Karthik NayakJul 12, 2015
  35. Duy NguyenJul 13, 2015
  36. Karthik NayakJul 13, 2015
  37. 09/10 tag.c: implement '--format' optionKarthik Nayak, Jul 9, 2015
  38. 10/10 tag.c: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jul 9, 2015
  39. Matthieu MoyJul 9, 2015
  40. Karthik NayakJul 11, 2015
  41. Matthieu MoyJul 11, 2015
  42. Junio C HamanoJul 10, 2015
  43. Karthik NayakJul 11, 2015
  44. Duy NguyenJul 12, 2015
  45. Duy NguyenJul 12, 2015
  46. Karthik NayakJul 12, 2015
  47. Duy NguyenJul 13, 2015
  48. Karthik NayakJul 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.