Re: [PATCH v2 08/10] tag.c: use 'ref-filter' APIs

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 12, 2015, 09:45 UTC
Message-ID: <CACsJy8AEEDEUE=nBvWVv426MWYzEmRSFFR1xF-cKKD2Lid9n4w@mail.gmail.com>
In-Reply-To: <559E53DC.2040804@gmail.com>

On Thu, Jul 9, 2015 at 5:58 PM, Karthik Nayak <karthik.188@gmail.com> wrote:

> -static int show_reference(const char *refname, const struct object_id *oid,
> -                         int flag, void *cb_data)
> -{

...

> -
> -       if (match_pattern(filter->name_patterns, refname)) {

....

Show 7 quoted lines

> -               printf("%-15s ", refname);
> -               show_tag_lines(oid, filter->lines);
> -               putchar('\n');
> -       }
> -
> -       return 0;
> -}

...

> +       if (filter->lines)
> +               format = "%(refname:shortalign=16)";
> +       else
> +               format = "%(refname:short)";

I can see this is a faithful conversion, but this looks line an opportunity to avoid this special limit 15/16. Even on git.git "git tag -l -n1" already breaks alignment with *.msysgit.* tags (ok maybe msysgit, not purely git.git) When you get to "branch -l", it calculates the max-width automatically so you probably need "%(refname:shortalign)" any way. "shortalign" (i.e. create the "align" version for every modifier) does not look good because it could double the number of modifiers and let's not thinking about truncation options or right alignment..

-- 
Duy