git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RCF/PATCH] Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 1, 2016, 07:57 UTC
Message-ID
<vpqpos11gv3.fsf@anie.imag.fr>
In-Reply-To
<20160601073037.GA14096@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Hmm. So I think this does fix some issues, but it also means that one's
> config.mak cannot use DEVELOPER as a base and then override particular
> flags.
You mean, using "make DEVELOPER=1" and then tweak CFLAGS in config.mak?

Well, you still can do "CFLAGS += ..." (the extra CFLAGS will come before the ones added by DEVELOPER instead of after), which should cover 99% use-cases.

You can't do "CFLAGS = $(filter-out ..., $(CFLAGS))" anymore indeed. But if you are at that level of customization, I'd say DEVELOPER isn't for you and you should just set CFLAGS directly.

Not really serious, but we can fix that easily. Patch follows.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Jeff KingNext: Matthieu Moy
Message 4 of 7 in “Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion”
  1. Makefile: move 'ifdef DEVELOPER' after config.mak* inclusionMatthieu Moy, May 31, 2016
  2. Junio C HamanoMay 31, 2016
  3. Jeff KingJun 1, 2016
  4. Matthieu MoyJun 1, 2016
  5. Makefile: add $(DEVELOPER_CFLAGS) variableMatthieu Moy, Jun 1, 2016
  6. Jeff KingJun 1, 2016
  7. Jeff KingJun 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.