git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RCF/PATCH] Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion

From
Jeff King <peff@peff.net>
Date
Jun 1, 2016, 08:05 UTC
Message-ID
<20160601080504.GB22528@sigill.intra.peff.net>
In-Reply-To
<20160601080348.GA22528@sigill.intra.peff.net>
On Wed, Jun 01, 2016 at 04:03:48AM -0400, Jeff King wrote:
Show 12 quoted lines
> Perhaps:
> 
>   DEVELOPER_CFLAGS += -Wfoo
>   DEVELOPER_CFLAGS += -Wbar
>   ...
>   -include config.mak
>   ...
>   ifdef DEVELOPER
>   CFLAGS += $(DEVELOPER_CFLAGS)
>   endif
> 
> would be more flexible.

Heh, our mails crossed, but I see you had the same idea. I think it is a strict improvement.

-Peff
Previous: Jeff King
Message 7 of 7 in “Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion”
  1. Makefile: move 'ifdef DEVELOPER' after config.mak* inclusionMatthieu Moy, May 31, 2016
  2. Junio C HamanoMay 31, 2016
  3. Jeff KingJun 1, 2016
  4. Matthieu MoyJun 1, 2016
  5. Makefile: add $(DEVELOPER_CFLAGS) variableMatthieu Moy, Jun 1, 2016
  6. Jeff KingJun 1, 2016
  7. Jeff KingJun 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.