Re: [RCF/PATCH] Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion

From: Jeff King <peff@peff.net>
Date: Jun 1, 2016, 07:30 UTC
Message-ID: <20160601073037.GA14096@sigill.intra.peff.net>
In-Reply-To: <20160531132443.5033-1-Matthieu.Moy@imag.fr>

On Tue, May 31, 2016 at 03:24:43PM +0200, Matthieu Moy wrote:

Show 17 quoted lines

> The DEVELOPER knob was introduced in 658df95 (add DEVELOPER makefile
> knob to check for acknowledged warnings, 2016-02-25), and works well
> when used as "make DEVELOPER=1", and when the configure script was not
> used.
> 
> However, the advice given in CodingGuidelines to add DEVELOPER=1 to
> config.mak does not: config.mak is included after testing for
> DEVELOPER in the Makefile, and at least GNU Make's manual specifies
> "Conditional directives are parsed immediately", hence the config.mak
> declaration is not visible at the time the conditional is evaluated.
> 
> Also, when using the configure script to generate a
> config.mak.autogen, the later file contained a "CFLAGS = <flags>"
> initialization, which overrode the "CFLAGS += -W..." triggered by
> DEVELOPER.
> 
> This patch fixes both issues.

Hmm. So I think this does fix some issues, but it also means that one's config.mak cannot use DEVELOPER as a base and then override particular flags.

I dunno if people want to do that or not. I do not use DEVELOPER myself because I have my own detailed config.mak that is a superset.

-Peff