Re: [PATCH 3/3] The "curl" executable is no longer required

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Jun 15, 2008, 11:23 UTC
Message-ID: <vpqmylnkkm4.fsf@bauges.imag.fr>
In-Reply-To: <200806151255.41055.johan@herland.net>

Johan Herland <johan@herland.net> writes:

Show 25 quoted lines

> On Sunday 15 June 2008, David Symonds wrote:
>> On Sun, Jun 15, 2008 at 8:16 PM, Johan Herland <johan@herland.net> wrote:
>> > diff --git a/git.spec.in b/git.spec.in
>> > index 97a26be..d946bb1 100644
>> > --- a/git.spec.in
>> > +++ b/git.spec.in
>> > @@ -12,7 +12,7 @@ BuildRequires:        zlib-devel >= 1.2,
>> > openssl-devel, curl-devel, expat-devel, gettex
>> >  BuildRoot:    
>> > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>> >
>> >  Requires:      perl-Git = %{version}-%{release}
>> > -Requires:      zlib >= 1.2, rsync, curl, less, openssh-clients, expat
>> > +Requires:      zlib >= 1.2, rsync, less, openssh-clients, expat
>> >  Provides:      git-core = %{version}-%{release}
>> >  Obsoletes:     git-core <= 1.5.4.2
>> >  Obsoletes:     git-p4
>>
>> Shouldn't libcurl still be listed as a requirement? Or is it statically
>> linked?
>
> 4 lines further up in git.spec.in:
>
> BuildRequires:	zlib-devel >= 1.2, openssl-devel, curl-devel, expat-devel, 
> gettext  %{!?_without_docs:, xmlto, asciidoc > 6.0.3}

I don't understand how that answers the question. Unless curl is statically linked, you need the library both at build time and at run time. For example, zlib-devel is needed here at build time, and zlib (without devel) is still in "Requires:". So, what's the difference between zlib and libcurl here?

-- 
Matthieu