Re: [PATCH 3/3] The "curl" executable is no longer required

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 15, 2008, 13:33 UTC
Message-ID: <200806151533.11742.jnareb@gmail.com>
In-Reply-To: <vpqej6ylx99.fsf@bauges.imag.fr>

Matthieu Moy wrote:

Show 19 quoted lines

> Johan Herland <johan@herland.net> writes:
>> On Sunday 15 June 2008, Jakub Narebski wrote:
>>
>>> It is not necessary to enumerate simple library dependencies, as
>>> rpmbuild _detects_ those dependencies during building binary RPMS.
> 
> Good to know, and that seems to be a valid argument ("seems to"
> because of my lack of knowledge of rpm, not lack of trust ;-) ).
> 
>>> Besides it worked without libcurl in Requires, so it should
>>> continue to work without it, isn't it?
> 
> It used to have a dependency on curl, which itself requires libcurl,
> so the dependency was implicit.
> 
>> Someone with more RPM knowledge will have to determine which is
>> right.
> 
> +1

Or simply remove 'curl' from 'Requires:' header, and check if rpmbuild would pick up libcurl dependency, and if resulting RPM has libcurl as requirement.

Fragment of "make rpm" output (word wrapped for better readibility):
[...]
Provides: git-core = 1.5.6.rc3.198.g368e0.dirty-1
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 
 rpmlib(PartialHardlinkSets) <= 4.0.4-1 
 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 
 rpmlib(VersionedDependencies) <= 3.0.3-1
Requires: /bin/sh /usr/bin/perl expat less 
 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.1) libc.so.6(GLIBC_2.1.3) 
 libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.2.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) 
 libcrypto.so.5 libcurl.so.3 libexpat.so.0 libz.so.1
 openssh-clients 
 perl >= 0:5.006 perl(Getopt::Long) perl(Git) perl(lib)
 perl(strict) perl(warnings) 
 perl-Git = 1.5.6.rc3.198.g368e0.dirty-1
 rsync zlib >= 1.2
Obsoletes: git-core <= 1.5.4.2 git-p4
[...]

$ rpm -q --requires -p git-1.5.6.rc3.198.g368e0.dirty-1.i386.rpm /bin/sh /usr/bin/perl expat less libc.so.6 [...] libcrypto.so.5 libcurl.so.3 libexpat.so.0 libz.so.1 [...]

As you can see rpmbuild picks up dependency on libcurl.

>From what I remember using automatically picked depndencies is

preferred solution, even if I cannot find it in "Maximum RPM" book.

HTH

-- 
Jakub Narebski
Poland