Re: [PATCH 3/3] The "curl" executable is no longer required

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 15, 2008, 11:42 UTC
Message-ID: <m3fxreq60t.fsf@localhost.localdomain>
In-Reply-To: <ee77f5c20806150352n6ccf00e9w8083a17d8c5c2326@mail.gmail.com>

"David Symonds" <dsymonds@gmail.com> writes:

Show 19 quoted lines

> On Sun, Jun 15, 2008 at 8:16 PM, Johan Herland <johan@herland.net> wrote:
> 
> > diff --git a/git.spec.in b/git.spec.in
> > index 97a26be..d946bb1 100644
> > --- a/git.spec.in
> > +++ b/git.spec.in
> > @@ -12,7 +12,7 @@ BuildRequires:        zlib-devel >= 1.2, openssl-devel,
> > curl-devel, expat-devel, gettex
> >  BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> >
> >  Requires:      perl-Git = %{version}-%{release}
> > -Requires:      zlib >= 1.2, rsync, curl, less, openssh-clients, expat
> > +Requires:      zlib >= 1.2, rsync, less, openssh-clients, expat
> >  Provides:      git-core = %{version}-%{release}
> >  Obsoletes:     git-core <= 1.5.4.2
> >  Obsoletes:     git-p4
> 
> Shouldn't libcurl still be listed as a requirement? Or is it
> statically linked?

It is not necessary to enumerate simple library dependencies, as rpmbuild _detects_ those dependencies during building binary RPMS. Only unusual requirements (on programs (tools) or on specific version of library) are needed to be added in Requires header.

This has nothing to do with BuildRequires. Besides it worked without libcurl in Requires, so it should continue to work without it, isn't it?

-- 
Jakub Narebski
Poland
ShadeHawk on #git