Re: [PATCH] revert: prettify fatal messages

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Nov 15, 2011, 10:04 UTC
Message-ID: <vpqlirhitvw.fsf@bauges.imag.fr>
In-Reply-To: <1321349492-5653-1-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 12 quoted lines

> Some of the fatal messages printed by revert and cherry-pick look ugly
> like the following:
>
>   fatal: Could not open .git/sequencer/todo.: No such file or directory
>
> The culprit here is the die_errno() function that takes a custom error
> message string as an argument and appends ": <message from errno>"
> before printing it.  So, we can fix the problem by not terminating the
> string argument to the function with a '.' (period).  Fatal messages
> look nicer now:
>
>   fatal: Could not open .git/sequencer/todo: No such file or directory

Sounds (obviously) good.

(I just misread the subject line at first, and understood that this was a revert of an earlier commit, while this is actually a commit touching the "revert" part of Git)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/