Re: [PATCH] revert: prettify fatal messages

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Nov 16, 2011, 06:23 UTC
Message-ID: <CALkWK0m+us0rCx61+SwSsKuO7qK5mbCs0MpoAzB4ja=wBA+Xjw@mail.gmail.com>
In-Reply-To: <7vvcqkswpu.fsf@alter.siamese.dyndns.org>

Hi,

Matthieu Moy wrote:

> (I just misread the subject line at first, and understood that this was> a revert of an earlier commit, while this is actually a commit touching> the "revert" part of Git)

Reminds me of an earlier note Jonathan made about the git-revert commit message format. To avoid confusion, reverts should always look like the following:

  Revert [commit message]

  This reverts commit [unabbreviated sha1 hex].

Junio C Hamano wrote:

> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>>  Candidate for 'maint'?
>
> Too minor to matter when 'master' is already at -rc2.

Ah, I haven't been paying much attention to these release cycles. I suppose we can put this patch in `master` after the release? I wince everytime I see these ugly fatal messages: it happens shockingly often while testing :)

Thanks.

-- Ram