git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revert: prettify fatal messages

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 16, 2011, 06:42 UTC
Message-ID
<20111116064013.GA13706@elie.hsd1.il.comcast.net>
In-Reply-To
<CALkWK0m+us0rCx61+SwSsKuO7qK5mbCs0MpoAzB4ja=wBA+Xjw@mail.gmail.com>
Ramkumar Ramachandra wrote:
Show 6 quoted lines
> To avoid confusion, reverts should always look
> like the following:
>
>   Revert [commit message]
>
>   This reverts commit [unabbreviated sha1 hex].
Don't forget the description of why it is being reverted. :)

Actually, I think Matthieu's confusion makes a lot of sense. I don't think it matters very much, but it can sometimes be clearer to say "cherry-pick/revert: remove spurious period in error message".

Another benefit to moving the juicy part to sequencer.c, I guess.
Previous: Ramkumar Ramachandra
Message 5 of 5 in “revert: prettify fatal messages”
  1. revert: prettify fatal messagesRamkumar Ramachandra, Nov 15, 2011
  2. Matthieu MoyNov 15, 2011
  3. Junio C HamanoNov 16, 2011
  4. Ramkumar RamachandraNov 16, 2011
  5. Jonathan NiederNov 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.