git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Patch Series v3 for "use the $( ... ) construct for command substitution"

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Apr 4, 2014, 17:40 UTC
Message-ID
<vpqk3b56lik.fsf@anie.imag.fr>
In-Reply-To
<20140404172946.GI6851@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
> If the script is "obviously correct" enough then there is no need
> to manually go through 140 files after that point.

The script cannot be "obviously correct", as there are a lot of potential corner-cases (nested `, nesting ` within ", comments, ...).

> If the only way to get this done is to actually manually review those
> 140 files, I just don't think it's worth it.

Honnestly, I went through the series once and it wasn't that painful. I need to do a more carefull review, but using "git diff --color-words=." it can be really fast.

Junio suggested splitting the series into batches of around 10 patches, sending one per week, but that would make too many patches IMHO (14 weeks ...).

I'd suggest doing a first batch with only scripts that are not tests and pushing this to git.git. Then the remaining series will be a bit less scary.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Jonathan NiederNext: Jonathan Nieder
Message 3 of 5 in “Patch Series v3 for "use the $( ... ) construct for command substitution"”
  1. Elia PintoApr 4, 2014
  2. Jonathan NiederApr 4, 2014
  3. Matthieu MoyApr 4, 2014
  4. Jonathan NiederApr 4, 2014
  5. Junio C HamanoApr 4, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.