From: Matthieu Moy Date: Fri, 04 Apr 2014 17:40:35 GMT Subject: Re: Patch Series v3 for "use the $( ... ) construct for command substitution" Message-ID: In-Reply-To: <20140404172946.GI6851@google.com> Jonathan Nieder writes: > If the script is "obviously correct" enough then there is no need > to manually go through 140 files after that point. The script cannot be "obviously correct", as there are a lot of potential corner-cases (nested `, nesting ` within ", comments, ...). > If the only way to get this done is to actually manually review those > 140 files, I just don't think it's worth it. Honnestly, I went through the series once and it wasn't that painful. I need to do a more carefull review, but using "git diff --color-words=." it can be really fast. Junio suggested splitting the series into batches of around 10 patches, sending one per week, but that would make too many patches IMHO (14 weeks ...). I'd suggest doing a first batch with only scripts that are not tests and pushing this to git.git. Then the remaining series will be a bit less scary. -- Matthieu Moy http://www-verimag.imag.fr/~moy/