git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Feb 27, 2013, 14:20 UTC
Message-ID
<vpqhakx4z4c.fsf@grenoble-inp.fr>
In-Reply-To
<32bae1f3c7159035ea3fb5f61ab622cbff30293a.1360677646.git.mina86@mina86.com>
Michal Nazarewicz <mpn@google.com> writes:
> +	$auth = Git::credential({
> +		'protocol' => 'smtp',
> +		'host' => join(':', $smtp_server, $smtp_server_port),

At this point, $smtp_server_port is not always defined. I just tested and got

Use of uninitialized value $smtp_server_port in join or string at git-send-email line 1077.

Other than that, the whole series looks good.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Michal NazarewiczNext: Junio C Hamano
Message 18 of 22 in “[PATCHv4 0/6] git-credential support in git-send-email”
  1. Michal NazarewiczFeb 12, 2013
  2. 1/6 Git.pm: allow command_close_bidi_pipe to be called as methodMichal Nazarewicz, Feb 12, 2013
  3. 2/6 Git.pm: fix example in command_close_bidi_pipe documentationMichal Nazarewicz, Feb 12, 2013
  4. 3/6 Git.pm: refactor command_close_bidi_pipe to use _cmd_closeMichal Nazarewicz, Feb 12, 2013
  5. Junio C HamanoFeb 12, 2013
  6. Jeff KingFeb 12, 2013
  7. Michal NazarewiczFeb 12, 2013
  8. Junio C HamanoFeb 12, 2013
  9. 4/6 Git.pm: allow pipes to be closed prior to calling command_close_bidi_pipeMichal Nazarewicz, Feb 12, 2013
  10. Jeff KingFeb 12, 2013
  11. Michal NazarewiczFeb 12, 2013
  12. Junio C HamanoFeb 12, 2013
  13. Jeff KingFeb 12, 2013
  14. Michal NazarewiczFeb 12, 2013
  15. 5/6 Git.pm: add interface for git credential commandMichal Nazarewicz, Feb 12, 2013
  16. Matthieu MoyFeb 27, 2013
  17. 6/6 git-send-email: use git credential to obtain passwordMichal Nazarewicz, Feb 12, 2013
  18. Matthieu MoyFeb 27, 2013
  19. Junio C HamanoFeb 27, 2013
  20. Michal NazarewiczFeb 27, 2013
  21. Matthieu MoyFeb 27, 2013
  22. Junio C HamanoFeb 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.