From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 27 Feb 2013 14:20:35 GMT
Subject: Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password
Message-ID: <vpqhakx4z4c.fsf@grenoble-inp.fr>
In-Reply-To: <32bae1f3c7159035ea3fb5f61ab622cbff30293a.1360677646.git.mina86@mina86.com>

Michal Nazarewicz <mpn@google.com> writes:

> +	$auth = Git::credential({
> +		'protocol' => 'smtp',
> +		'host' => join(':', $smtp_server, $smtp_server_port),

At this point, $smtp_server_port is not always defined. I just tested
and got

Use of uninitialized value $smtp_server_port in join or string at
git-send-email line 1077.

Other than that, the whole series looks good.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/