[PATCHv4 1/6] Git.pm: allow command_close_bidi_pipe to be called as method
- From
- Michal Nazarewicz <mpn@google.com>
- Date
- Feb 12, 2013, 14:02 UTC
- Message-ID
- <df0bb01e70629e8170b022867c6e70a8d1b88768.1360677646.git.mina86@mina86.com>
- In-Reply-To
- <cover.1360677646.git.mina86@mina86.com>
From: Michal Nazarewicz <mina86@mina86.com>
The documentation of command_close_bidi_pipe() claims that it can be called as a method, but it does not check whether the first argument is $self or not assuming the latter. Using _maybe_self() fixes this.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --- perl/Git.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/Git.pm index 931047c..bbb753a 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -430,7 +430,7 @@ have more complicated structure. sub command_close_bidi_pipe { local $?; - my ($pid, $in, $out, $ctx) = @_; + my ($self, $pid, $in, $out, $ctx) = _maybe_self(@_); foreach my $fh ($in, $out) { unless (close $fh) { if ($!) {
-- 1.8.1.3.572.g32bae1f