git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] status: introduce status.displayCommentChar to disable display of #

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Aug 28, 2013, 12:43 UTC
Message-ID
<vpqhaeaasuf.fsf@anie.imag.fr>
In-Reply-To
<521DD8EC.6050800@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
> How does your solution work when dirty submodules are involved and
> submodule status is included?f
Badly ;-).

I didn't notice the subcommand call for submodules summary. It's a bit more tricky to get right, as the "git sumbodule summary --for-status" call did not know whether it was called from commit or from status.

I fixed this by adding a --[no-]-display-comment-char to git submodule summary.

Show 5 quoted lines
>> +test_expect_success 'status with status.displayCommentChar=false' '
>> +	"$PERL_PATH" -pi -e "s/^\# //; s/^\#$//; s/^#\t/\t/" expect &&
>
> Perl's -i does not work on Windows when no backup file extension is given.
> Therefore, please use a temporary file or "... -pi.bak ..."
OK I didn't know that. I went the old good sed+mv way.
New series comming.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Johannes SixtNext: Matthieu Moy
Message 3 of 21 in “status: introduce status.displayCommentChar to disable display of #”
  1. status: introduce status.displayCommentChar to disable display of #Matthieu Moy, Aug 28, 2013
  2. Johannes SixtAug 28, 2013
  3. Matthieu MoyAug 28, 2013
  4. 1/3 builtin/stripspace.c: fix broken indentationMatthieu Moy, Aug 28, 2013
  5. 2/3 submodule: introduce --[no-]display-comment-charMatthieu Moy, Aug 28, 2013
  6. Jens LehmannAug 28, 2013
  7. Matthieu MoyAug 29, 2013
  8. 3/3 status: introduce status.displayCommentChar to disable display of #Matthieu Moy, Aug 28, 2013
  9. Junio C HamanoAug 28, 2013
  10. Junio C HamanoAug 28, 2013
  11. Jeff KingAug 28, 2013
  12. Junio C HamanoAug 28, 2013
  13. David AguilarAug 28, 2013
  14. Junio C HamanoAug 28, 2013
  15. Matthieu MoyAug 29, 2013
  16. brian m. carlsonAug 31, 2013
  17. Matthieu MoyAug 28, 2013
  18. Junio C HamanoAug 28, 2013
  19. Junio C HamanoAug 28, 2013
  20. Jonathan NiederAug 28, 2013
  21. Matthieu MoyAug 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.