Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 28, 2013, 23:13 UTC
Message-ID: <20130828231326.GA4110@google.com>
In-Reply-To: <1377694024-24173-3-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy wrote:

Show 6 quoted lines

> Historically, "git status" needed to prefix each output line with '#' so
> that the output could be added as comment to the commit message. This
> prefix comment has no real purpose when "git status" is ran from the
> command-line, and this may distract users from the real content.
>
> Allow the user to disable this prefix comment.

Why not do this unconditionally?

>                                                In the long run, if users
> like the non-prefix output, it may make sense to flip the default value
> to true.

Hmm, do you mean that the configuration is to give the change-averse some time to get used to the new output? I think it would make sense to do it all at once (and even think that that would be less confusing).

The rest of the idea and execution seem sane.

Thanks, Jonathan