Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Aug 29, 2013, 06:58 UTC
- Message-ID
- <vpqeh9d3rwe.fsf@anie.imag.fr>
- In-Reply-To
- <CAJDDKr6RDiAxgUdaE5aH4-wxYRY7fKnUukX1D-t07=-_P0CZAg@mail.gmail.com>
David Aguilar <davvid@gmail.com> writes:
> I have a poor imagination and cannot imagine why it needs to be > switchable.
I could not either, but I found the reason in the commit message: eff80a9fd990
Some users do want to write a line that begin with a pound sign, #,
in their commit log message. Many tracking system recognise
a token of #<bugid> form, for example.
The support we offer these use cases is not very friendly to the end
users. They have a choice between
- Don't do it. Avoid such a line by rewrapping or indenting; and
- Use --cleanup=whitespace but remove all the hint lines we add.
Give them a way to set a custom comment char, e.g.
$ git -c core.commentchar="%" commit
so that they do not have to do either of the two workarounds.I personnally think allowing an escape scheme (\#) would have been better.
But as Junio said, it's too late. My change is not about commentchar customizability, but about disabling the comment in "git status".
-- Matthieu Moy http://www-verimag.imag.fr/~moy/