git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Mar 10, 2014, 09:05 UTC
Message-ID
<vpqha76e842.fsf@anie.imag.fr>
In-Reply-To
<loom.20140310T094407-5@post.gmane.org>
Nemina Amarasinghe <neminaa@gmail.com> writes:
Show 9 quoted lines
>> 
>> Nemina Amarasinghe <neminaa <at> gmail.com> writes:
>> 
>> Is it me, or is (origin || !origin) a tautology?
>> 
> Thanks for the advices Matthieu. I will go through the documentations again. 
> Is there anything wrong with my logic? 
> What I wanted to express is
> ((!remote_is_branch && origin) || (!remote_is_branch || !origin))
(The second || should be a && in this sentence)

I'm not saying your rewrite is incorrect, but there's no reason to keep (origin || !origin) in a logical formula.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Nemina AmarasingheNext: David Kastrup
Message 6 of 14 in “simplified the chain if() statements of install_branch_config() function in branch.c”
  1. simplified the chain if() statements of install_branch_config() function in branch.cNemina Amarasinghe, Mar 10, 2014
  2. Nemina AmarasingheMar 10, 2014
  3. Matthieu MoyMar 10, 2014
  4. David KastrupMar 10, 2014
  5. Nemina AmarasingheMar 10, 2014
  6. Matthieu MoyMar 10, 2014
  7. David KastrupMar 10, 2014
  8. Nemina AmarasingheMar 10, 2014
  9. David KastrupMar 10, 2014
  10. Eric SunshineMar 10, 2014
  11. Nemina AmarasingheMar 11, 2014
  12. Eric SunshineMar 11, 2014
  13. Nemina AmarasingheMar 11, 2014
  14. Eric SunshineMar 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.