git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][GSoC]simplified branch.c:install_branch_config() if() statement

From
NANemina Amarasinghe <neminaa@gmail.com>
Date
Mar 11, 2014, 07:16 UTC
Message-ID
<loom.20140311T081018-894@post.gmane.org>
In-Reply-To
<CAPig+cRAqEQ8320Gq2Njoioq5UU=d+W+hzF+YZAZ7Po9XjMq0g@mail.gmail.com>

I hope this is the correct format for patch. Please comment on this if something is wrong.

Signed-off-by:Nemina Amarasinghe <neminaa@gmail.com>
---
 branch.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/branch.c b/branch.c
index 0304a7a..fd93603 100644
--- a/branch.c
+++ b/branch.c
@@ -87,12 +87,7 @@ void install_branch_config(int flag, const char *local,
const char *origin, cons
 				  _("Branch %s set up to track local branch %s by rebasing.") :
 				  _("Branch %s set up to track local branch %s."),
 				  local, shortname);
-		else if (!remote_is_branch && origin)
-			printf_ln(rebasing ?
-				  _("Branch %s set up to track remote ref %s by rebasing.") :
-				  _("Branch %s set up to track remote ref %s."),
-				  local, remote);
-		else if (!remote_is_branch && !origin)
+		else if (!remote_is_branch)
 			printf_ln(rebasing ?
 				  _("Branch %s set up to track remote ref %s by rebasing.") :
 				  _("Branch %s set up to track remote ref %s."),
-- 
1.9.0.152.g6ab4ae2
Previous: Eric SunshineNext: Eric Sunshine
Message 13 of 14 in “simplified the chain if() statements of install_branch_config() function in branch.c”
  1. simplified the chain if() statements of install_branch_config() function in branch.cNemina Amarasinghe, Mar 10, 2014
  2. Nemina AmarasingheMar 10, 2014
  3. Matthieu MoyMar 10, 2014
  4. David KastrupMar 10, 2014
  5. Nemina AmarasingheMar 10, 2014
  6. Matthieu MoyMar 10, 2014
  7. David KastrupMar 10, 2014
  8. Nemina AmarasingheMar 10, 2014
  9. David KastrupMar 10, 2014
  10. Eric SunshineMar 10, 2014
  11. Nemina AmarasingheMar 11, 2014
  12. Eric SunshineMar 11, 2014
  13. Nemina AmarasingheMar 11, 2014
  14. Eric SunshineMar 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.