From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 10 Mar 2014 09:05:49 GMT
Subject: Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c
Message-ID: <vpqha76e842.fsf@anie.imag.fr>
In-Reply-To: <loom.20140310T094407-5@post.gmane.org>

Nemina Amarasinghe <neminaa@gmail.com> writes:

>> 
>> Nemina Amarasinghe <neminaa <at> gmail.com> writes:
>> 
>> Is it me, or is (origin || !origin) a tautology?
>> 
> Thanks for the advices Matthieu. I will go through the documentations again. 
> Is there anything wrong with my logic? 
> What I wanted to express is
> ((!remote_is_branch && origin) || (!remote_is_branch || !origin))

(The second || should be a && in this sentence)

I'm not saying your rewrite is incorrect, but there's no reason to keep
(origin || !origin) in a logical formula.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/