Re: [PATCH v3 3/3] doc: change configuration variables format
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 6, 2016, 14:09 UTC
- Message-ID
- <vpqfusqmmsl.fsf@anie.imag.fr>
- In-Reply-To
- <20160606100905.23006-4-tom.russello@grenoble-inp.org>
Tom Russello <tom.russello@grenoble-inp.org> writes:
> As a first step,
Is this your second first step? ;-)
As 3rd and 4th first steps, I'd suggest:
Format short options properly: perl -pi -e "s/'(-[a-z])'/\`\$1\`/g" *.txt
Format long options properly: perl -pi -e "s/'(--[a-z][a-z=<>-]*)'/\`\$1\`/g" *.txt
This does not have to be done right now. Large series doing only reformatting like this tend to create conflicts with in-flight topics so it may be better to split it into several series anyway.
About conflicts, I just checked: the existing patch series creates one trivial conflict with pu, and my suggested fix for long options creates one more. Seems manageable.
For now, I went carefully through the patches. With or without my suggested changes/additions, the series is now
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Thanks,
-- Matthieu Moy http://www-verimag.imag.fr/~moy/