Re: [RFC/PATCH] Formatting variables in the documentation

From: Jeff King <peff@peff.net>
Date: May 26, 2016, 16:39 UTC
Message-ID: <20160526163910.GA18597@sigill.intra.peff.net>
In-Reply-To: <xmqqbn3sydvk.fsf@gitster.mtv.corp.google.com>

On Thu, May 26, 2016 at 09:37:19AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> >> There was no particular "caveat" raised there to recommend against
> >> using this on particular versions of tools or platforms.  It was
> >> inertia that has kept the new optional feature "optional".
> >
> > Thanks for digging. That matches my recollection and the limited
> > research I did more recently.
> 
> For completeness's sake I should point out that the discussion on
> the first thread did point out some version-dependent issues.  But
> with 79c461d5 (docs: default to more modern toolset, 2010-11-19), we
> declared the problematic versions obsolete; I suspect that it is
> safe to assume that those who would be hurt by flipping the default
> would already be extinct after 6 years since then.

Yeah, I'd agree, though that may be worth mentioning in the commit message.

Show 8 quoted lines

> > OK. I was trying to see if (1) could be low-hanging fruit for any of the
> > newcomers, but at this point it probably makes sense for you to just
> > write the patch.
> 
> Leaving it as low-hanging fruit is actually a good idea.
> 
> I was thinking about flipping it in Meta/dodoc.sh, which would
> update the git-manpages.git repository whose mirrors are found at

Ah, right. I was thinking that the patch would go to "master" first, but there is no reason it could not be flipped independently for your build process.

-Peff