Re: [PATCH v3 2/3] doc: change environment variables format

From: Tom Russello <tom.russello@grenoble-inp.org>
Date: Jun 6, 2016, 16:34 UTC
Message-ID: <57e1e906-1314-e774-4ca6-89cf772ce19d@grenoble-inp.org>
In-Reply-To: <vpqinxmmmu8.fsf@anie.imag.fr>

On 06/06/16 16:08, Matthieu Moy wrote:

Show 5 quoted lines

> I'd add to the commit message that one of the goals of this patch is to
> make the use "mostly consistent" with CodingGuidelines, so that people
> writting new doc by mimicking the existing one later get a good
> probability of getting it right even if they didn't read
> CodingGuidelines.

Agreed.

Show 11 quoted lines

>> @@ -619,7 +619,7 @@ core.excludesFile::
>>  core.askPass::
>>  	Some commands (e.g. svn and http interfaces) that interactively
>>  	ask for a password can be told to use an external program given
>> -	via the value of this variable. Can be overridden by the 'GIT_ASKPASS'
>> +	via the value of this variable. Can be overridden by the `GIT_ASKPASS`
>>  	environment variable. If not set, fall back to the value of the
>>  	'SSH_ASKPASS' environment variable or, failing that, a simple password
>>  	prompt. The external program shall be given a suitable prompt as
> 
> We now have a minor inconsistency between GIT_ASKPASS and SSH_ASKPASS.

This is the side effect of changing only one pattern (GIT_*)

> You can catch this one and a handful others with
> 
>   git grep "'[A-Z_]*' environment"

With this regex, we can even catch environment variables without any format or prefixed with '$':

git grep ".'\?\$\?[0-9A-Z_]\+'\? environment "

> (That would be a separate patch)

I'm on it.

Thank you.