Re: [PATCH 3/3] rebase: turn git-rebase--*.sh into separate programs
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Feb 17, 2016, 14:05 UTC
- Message-ID
- <vpqa8mzjuu9.fsf@anie.imag.fr>
- In-Reply-To
- <1455716201-29784-4-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 16 quoted lines
> + git_quiet=$GIT_QUIET > + git_reflog_action=$GIT_REFLOG_ACTION > + export GIT_PAGER > + # these are for write_basic_state() > + export allow_rerere_autoupdate gpg_sign_opt head_name onto > + export orig_head state_dir strategy strategy_opts verbose > + # common variables > + export action git_reflog_action git_quiet keep_empty > + export rebase_root restrict_revision revisions upstream > + # git-rebase--am specific > + export git_am_opt > + # git-rebase--interactive specific > + export autosquash cmd force_rebase onto_name preserve_merges > + export squash_onto switch_to > + > + exec git-rebase--$type
This is a good first step, but we may later want to turn these environment variables into command-line options for the helpers. Or not.
On overall, the series looks good to me, but I don't have time for a detailed review.
Thanks,
-- Matthieu Moy http://www-verimag.imag.fr/~moy/