Re: [PATCH] [BUG FIXED 2] git-add (-a|-u) and -n support

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Oct 14, 2007, 13:25 UTC
Message-ID: <vpq3awd25hs.fsf@bauges.imag.fr>
In-Reply-To: <E857D120-787F-460B-A167-4B5F4BD2C3B5@mit.edu>

Michael Witten <mfwitten@MIT.EDU> writes:

> Subject: [PATCH] git-add now understands two kinds of update:
>
>  	-u: update as before
>  	-a: update all as in a true 'git commit -a'

I don't find the option set very intuitive. I'd prefer

  - git add -u . => update the current directory as before
  - git add -u   => update all files from the root.

But your solution has the advantage of being backward compatible, so, no strong opinion here.

(side note: also, while you're here, it would be nice to have a single command to do "git add .; git add -u", i.e add all unknown files, update all existing files, and actally remove all deleted files. In one word, synchronize the index with the working tree completely. Perhaps "-a" would be a good name for that, not sure)

>  builtin-add.c |   69 +++++++++++++++++++++++++++++++++++++
> +-------------------

Your patch is whitespace-damaged. I don't know how to fix that for Apple Mail, but git-send-email can help.

>  static const char builtin_add_usage[] =
>  "git-add [-n] [-v] [-f] [--interactive | -i] [-u] [--refresh] [--]
> <filepattern>...";

You should document -a here, and in Documentation/git-add.txt if you introduce it.

-- 
Matthieu