Re: [PATCH] [BUG FIXED 2] git-add (-a|-u) and -n support

From: Michael Witten <mfwitten@mit.edu>
Date: Oct 15, 2007, 14:47 UTC
Message-ID: <85EE4C64-2174-45D3-A459-69746C9CD51C@mit.edu>
In-Reply-To: <20071015143137.GA7351@diana.vm.bytemark.co.uk>

On 15 Oct 2007, at 10:31:37 AM, Karl Hasselström wrote:

Show 17 quoted lines

> On 2007-10-14 18:00:44 -0400, Michael Witten wrote:
>
>> Here's compromise that is backwards compatible. For both git-add and
>> git-commit:
>>
>>       -a dir [dir2 ...] => all changes in the given dirs.
>>       -a                => all changes from the root.
>>
>> Then we can just leave -u in place for now, and mark it as
>> deprecated.
>>
>> In any case, the goal is to make the intuition solid between
>> git-commit and git-add.
>
> As I recall, Junio had some specific reason for calling the flag -u
> instead of -a. Search in the list archive for the patch that
> introduced the flag, or wait till he gets back and ask him.

I have a feeling it was because -u currently just updates modified files in the current directory, while -a updated all modified files.

Fortunately, the suggestion above does not break anything.

Michael Witten

P.S. When is Junio coming back? I know I know... Look through the archives. :-P