Re: [PATCH] git-add (-a|-u) and -n support
- From
Jeff King <peff@peff.net>
- Date
- Oct 15, 2007, 04:20 UTC
- Message-ID
- <20071015042028.GB4844@coredump.intra.peff.net>
- In-Reply-To
- <E1DCA1D1-1ED3-498A-A919-9EBAF3BA0870@mit.edu>
On Sun, Oct 14, 2007 at 06:26:28AM -0400, Michael Witten wrote:
> The patch is below, but you can also download it from > http://web.mit.edu/mfwitten/git/0001-git-add-now-understands-two-kinds-of-update.patch
Hi Michael,
Thank you for submitting a patch! However, please make sure you read SubmittingPatches carefully. Your message should consist of the regular mail headers (as generated by git-format-patch + whatever else you want to add), the commit message, a line containing "---", and then the diff. Any cover letter material should go after the "---".
IOW, the format the git-format-patch generates is actually a mail in the correct format. If you can convince your mailer to use that as a template for sending a mail, that is the best bet.
I know these seem like little things, but they make the life of the maintainer much easier, as it means your patch and commit message can be applied directly by the git tools.
-Peff "policing the list with an iron fist in Junio's absence" King