Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Mar 18, 2015, 16:23 UTC
- Message-ID
- <vpq3852ff5j.fsf@anie.imag.fr>
- In-Reply-To
- <1426662276-8728-3-git-send-email-pyokagan@gmail.com>
I would personnally prefer to see this squashed with PATCH 2/4: pushing the "bisectable history" principle a bit, the state between patches 2 and 3 could be considered broken because the code does not do what the documentation says. And as a reviewer, I like having pieces of docs linked to the patch they document.
Paul Tan <pyokagan@gmail.com> writes:
> +Credential storage will per default
Not a native, but "per default" sounds weird and "by default" seems far more common.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/