Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence
- From
Paul Tan <pyokagan@gmail.com>
- Date
- Mar 21, 2015, 05:59 UTC
- Message-ID
- <CACRoPnTqSk=v6ambpsr1+3yP27oVsz4PGkfY8iPrsqgNyyv+yg@mail.gmail.com>
- In-Reply-To
- <vpq3852ff5j.fsf@anie.imag.fr>
Hi,
On Thu, Mar 19, 2015 at 12:23 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 5 quoted lines
> I would personnally prefer to see this squashed with PATCH 2/4: pushing > the "bisectable history" principle a bit, the state between patches 2 > and 3 could be considered broken because the code does not do what the > documentation says. And as a reviewer, I like having pieces of docs > linked to the patch they document.
Yup, I can see what you mean. Will squash on the next version.
Show 6 quoted lines
> Paul Tan <pyokagan@gmail.com> writes: > >> +Credential storage will per default > > Not a native, but "per default" sounds weird and "by default" seems far > more common.
Ah right, that definitely sounds better. Thanks.