git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 4/4] t0302: test credential-store support for XDG_CONFIG_HOME

From
Paul Tan <pyokagan@gmail.com>
Date
Mar 21, 2015, 10:01 UTC
Message-ID
<CACRoPnRC0V6MZvfBBG9sx4vxnC4J1UdyiGoXaxbRHd=PZjC_kA@mail.gmail.com>
In-Reply-To
<vpqy4mtrtxm.fsf@anie.imag.fr>
Hi,

On Thu, Mar 19, 2015 at 9:35 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 12 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> I also tend to favor adding "failure" tests which are flipped to
>> "success" when appropriate, however, as this is an entirely new
>> feature, this approach may be unsuitable (and perhaps overkill).
>
> I can buy the "overkill", but not unsuitable. Even for new features, the
> tests should fail before and pass after. Otherwise, the tests are not
> testing the feature. Actually, this is a strong principle in test-driven
> development: don't write code unless you have a failing test.
>
> But I was just thinking out loudly, certainly not requesting a change.

I also think that the tests belong in their own patch as the patch is really long compared to the rest of the patch series and it makes it easier for me to respond to comments as well.

Putting the tests before the implementation, though, makes sense in this case as it is just an implementation of a well-defined set of requirements. Some tests will still pass with or without the feature, but that is the requirement of the feature -- which is to not be enabled until the user explicitly creates the xdg file. Will re-order the patch series in the next version.

Thanks.

Regards, Paul

Previous: Matthieu MoyNext: Eric Sunshine
Message 10 of 15 in “git-credential-store: support multiple credential files”
  1. 1/4 git-credential-store: support multiple credential filesPaul Tan, Mar 18, 2015
  2. 2/4 git-credential-store: support XDG_CONFIG_HOMEPaul Tan, Mar 18, 2015
  3. 3/4 docs/git-credential-store: document XDG file and precedencePaul Tan, Mar 18, 2015
  4. Matthieu MoyMar 18, 2015
  5. Paul TanMar 21, 2015
  6. 4/4 t0302: test credential-store support for XDG_CONFIG_HOMEPaul Tan, Mar 18, 2015
  7. Matthieu MoyMar 18, 2015
  8. Eric SunshineMar 18, 2015
  9. Matthieu MoyMar 19, 2015
  10. Paul TanMar 21, 2015
  11. Eric SunshineMar 18, 2015
  12. Eric SunshineMar 19, 2015
  13. Paul TanMar 21, 2015
  14. Eric SunshineMar 23, 2015
  15. Matthieu MoyMar 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.