Re: Git Bug report

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Oct 6, 2011, 16:26 UTC
Message-ID: <vpq1uuq13yz.fsf@bauges.imag.fr>
In-Reply-To: <7vy5wy145q.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

>  If we cannot tell if it is or is not
> a GIT_DIR, we should error out---the reason we cannot tell most likely is
> because we cannot read it, and such a file, if it is not a GIT_DIR, cannot
> be tracked in the real GIT_DIR at a higher level, and if it is a GIT_DIR,
> we cannot use it to record updates or inspect existing history.

Plus, the user may have removed the permission on the .git directory by mistake, and it would be very surprising behavior if git ran without complaining using a higher level GIT_DIR (i.e. a more or less arbitrary repo as far as the user is concerned ...)

> How's that sound as a guideline?

Sounds reasonable, yes.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/