Re: Git Bug report

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Oct 5, 2011, 21:56 UTC
Message-ID: <CACsJy8CZT7=b69mPyLPuggH3QPH5cQfbJXD0PWZopKQ03D6MXQ@mail.gmail.com>
In-Reply-To: <7vlisz8jur.fsf@alter.siamese.dyndns.org>

On Thu, Oct 6, 2011 at 3:49 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>> So if:
>> .git/ is a directory with not enough permissions.
>> ../.git/ is a directory with enough permissions.
>>
>> git would today use ../.git. You suggest that git instead would die
>> because a .git/ exists? (I'm not saying this is wrong or right).
>
> For that matter, if you have .git/ that is a directory but is not a
> repository, and ../.git/ that is, the same situation would arise. I do not
> think we should die because .git/ is not a git repository. I do not know
> if we should even warn about it.

Probably not. On the other hand we should show user how we ignored .git if we find no good repository in the end. So maybe it's a good idea to queue up warnings and only print before git calls die("Not a repository").

-- 
Duy