Re: Git Bug report

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 5, 2011, 16:49 UTC
Message-ID: <7vlisz8jur.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111005072235.GA12600@kolya>

Fredrik Gustafsson <iveqy@iveqy.com> writes:

Show 16 quoted lines

> On Tue, Oct 04, 2011 at 05:24:03PM -0400, Federico Lucifredi wrote:
>>  Found a minor bug in git today - the error message reported is not
>> correct when trying to access a repo that is not accessible
>> permission-wise:
>> 
>> > federico@skyplex:/etc$ git log
>> > fatal: Not a git repository (or any of the parent directories): .git
>> 
>> with correct access permissions, everything works as expected.
>
> So if:
> .git/ is a directory with not enought permissions.
> ../.git/ is a directory with enought permissions.
>
> git would today use ../.git. You suggest that git instead would die
> because a .git/ exists? (I'm not saying this is wrong or right).

For that matter, if you have .git/ that is a directory but is not a repository, and ../.git/ that is, the same situation would arise. I do not think we should die because .git/ is not a git repository. I do not know if we should even warn about it.