git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] mw-to-git: use git-credential's URL parser

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 18, 2012, 12:37 UTC
Message-ID
<vpq1uk9jldk.fsf@bauges.imag.fr>
In-Reply-To
<20120718122848.GB11482@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> I started with a version that did that, but there are two complications:
>
>   1. credential_write needs to know that the 'url' field must come
>      first, as it overwrites the other fields. So we end up
>      special-casing it either way.

Right, I didn't think of that. But you'd have to special-case it only within credential_run, and not for the caller.

>   2. Git hands us back the broken-down version, which we add to the
>      credential.

We don't add it, but already replace the whole structure. This is somehow needed because "git credential fill" can remove fields from the structure (the path attribute is removed with credential.useHttpPath=false). So, this point doesn't seem problematic.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Jeff KingNext: Jeff King
Message 10 of 14 in “mediawiki/credential cleanups”
  1. 0/4 mediawiki/credential cleanupsJeff King, Jul 18, 2012
  2. 1/4 docs/credential: minor clarity fixupsJeff King, Jul 18, 2012
  3. 2/4 mw-to-git: check blank credential attributes via lengthJeff King, Jul 18, 2012
  4. 3/4 credential: convert "url" attribute into its parsed subpartsJeff King, Jul 18, 2012
  5. Matthieu MoyJul 18, 2012
  6. Jeff KingJul 18, 2012
  7. 4/4 mw-to-git: use git-credential's URL parserJeff King, Jul 18, 2012
  8. Matthieu MoyJul 18, 2012
  9. Jeff KingJul 18, 2012
  10. Matthieu MoyJul 18, 2012
  11. Jeff KingJul 18, 2012
  12. 4/4 mw-to-git: use git-credential's URL parserJeff King, Jul 18, 2012
  13. Matthieu MoyJul 18, 2012
  14. Matthieu MoyJul 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.