From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 18 Jul 2012 12:37:27 GMT
Subject: Re: [PATCH 4/4] mw-to-git: use git-credential's URL parser
Message-ID: <vpq1uk9jldk.fsf@bauges.imag.fr>
In-Reply-To: <20120718122848.GB11482@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I started with a version that did that, but there are two complications:
>
>   1. credential_write needs to know that the 'url' field must come
>      first, as it overwrites the other fields. So we end up
>      special-casing it either way.

Right, I didn't think of that. But you'd have to special-case it only
within credential_run, and not for the caller.

>   2. Git hands us back the broken-down version, which we add to the
>      credential.

We don't add it, but already replace the whole structure. This is
somehow needed because "git credential fill" can remove fields from the
structure (the path attribute is removed with
credential.useHttpPath=false). So, this point doesn't seem problematic.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/