[PATCH 2/4] mw-to-git: check blank credential attributes via length
- From
Jeff King <peff@peff.net>
- Date
- Jul 18, 2012, 12:04 UTC
- Message-ID
- <20120718120430.GB6726@sigill.intra.peff.net>
- In-Reply-To
- <20120718120307.GA6399@sigill.intra.peff.net>
When writing a credential to git-credential, we omit fields that do not have a true value. This will skip empty or undefined fields (which we want), but will also accidentally skip usernames or passwords which happen to have a non-true value (e.g., "0"). Be more careful by checking for non-zero length.
Signed-off-by: Jeff King <peff@peff.net> --- contrib/mw-to-git/git-remote-mediawiki | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki index accd70a..b06f27b 100755 --- a/contrib/mw-to-git/git-remote-mediawiki +++ b/contrib/mw-to-git/git-remote-mediawiki @@ -207,7 +207,7 @@ sub credential_write { my $credential = shift; my $writer = shift; while (my ($key, $value) = each(%$credential) ) { - if ($value) { + if (length $value) { print $writer "$key=$value\n"; } }
-- 1.7.10.5.40.g059818d