git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/t0006: specify timezone as EST5 not EST to comply with POSIX

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jul 6, 2010, 23:34 UTC
Message-ID
<upBu73z-yHJSTQ58c-Br0BxGwDzKGa1fPzZXA71AfI3kG3dMsRRPOX76JRJVhEOcDGoNaf1z9Lg@cipher.nrlssc.navy.mil>
In-Reply-To
<20100704110017.GA23121@sigill.intra.peff.net>
From: Brandon Casey <drafnel@gmail.com>

POSIX requires that both the timezone "standard" and "offset" be specified in the TZ environment variable. This causes a problem on IRIX which does not understand the timezone 'EST'.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---

I guess 'EST' is an alias? for EST5EDT? Linux and Solaris both grok EST just fine. POSIX says the offset is required. I don't see any mention of aliases.

-brandon
 t/t0006-date.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t0006-date.sh b/t/t0006-date.sh
index b2df4fe..1d4d0a5 100755
--- a/t/t0006-date.sh
+++ b/t/t0006-date.sh
@@ -39,7 +39,7 @@ check_parse 2008-02 bad
 check_parse 2008-02-14 bad
 check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 +0000'
 check_parse '2008-02-14 20:30:45 -0500' '2008-02-14 20:30:45 -0500'
-check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 -0500' EST
+check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 -0500' EST5
 
 check_approxidate() {
 	echo "$1 -> $2 +0000" >expect
-- 
1.6.6.2
Previous: Junio C HamanoNext: Alex Riesen
Message 4 of 11 in “t0006: test timezone parsing”
  1. 1/2 t0006: test timezone parsingJeff King, Jul 4, 2010
  2. 2/2 parse_date: fix signedness in timezone calculationJeff King, Jul 4, 2010
  3. Junio C HamanoJul 6, 2010
  4. t/t0006: specify timezone as EST5 not EST to comply with POSIXBrandon Casey, Jul 6, 2010
  5. Alex RiesenJul 7, 2010
  6. Jeff KingJul 7, 2010
  7. Andreas SchwabJul 7, 2010
  8. Junio C HamanoJul 6, 2010
  9. Jeff KingJul 6, 2010
  10. Jeff KingJul 6, 2010
  11. Junio C HamanoJul 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.