git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/t0006: specify timezone as EST5 not EST to comply with POSIX

From
Jeff King <peff@peff.net>
Date
Jul 7, 2010, 18:12 UTC
Message-ID
<20100707181221.GA5299@coredump.intra.peff.net>
In-Reply-To
<upBu73z-yHJSTQ58c-Br0BxGwDzKGa1fPzZXA71AfI3kG3dMsRRPOX76JRJVhEOcDGoNaf1z9Lg@cipher.nrlssc.navy.mil>
On Tue, Jul 06, 2010 at 06:34:20PM -0500, Brandon Casey wrote:
Show 12 quoted lines
> From: Brandon Casey <drafnel@gmail.com>
> 
> POSIX requires that both the timezone "standard" and "offset" be specified
> in the TZ environment variable.  This causes a problem on IRIX which does
> not understand the timezone 'EST'.
> 
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
> 
> I guess 'EST' is an alias? for EST5EDT?  Linux and Solaris both grok EST
> just fine.  POSIX says the offset is required.  I don't see any mention of
> aliases.

Yeah, I believe it is the same as EST5EDT. Which time zone isn't really important. The main thing is that it be a negative offset from UTC, and that we be able to convert the zone name into a numeric offset for the date specified in the test (which is totally arbitrary and can be tweaked if need be to avoid daylight saving issues).

So I think your patch is fine, but we can look harder if somebody finds a platform that doesn't understand EST5.

-Peff
Previous: Alex RiesenNext: Andreas Schwab
Message 6 of 11 in “t0006: test timezone parsing”
  1. 1/2 t0006: test timezone parsingJeff King, Jul 4, 2010
  2. 2/2 parse_date: fix signedness in timezone calculationJeff King, Jul 4, 2010
  3. Junio C HamanoJul 6, 2010
  4. t/t0006: specify timezone as EST5 not EST to comply with POSIXBrandon Casey, Jul 6, 2010
  5. Alex RiesenJul 7, 2010
  6. Jeff KingJul 7, 2010
  7. Andreas SchwabJul 7, 2010
  8. Junio C HamanoJul 6, 2010
  9. Jeff KingJul 6, 2010
  10. Jeff KingJul 6, 2010
  11. Junio C HamanoJul 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.