Re: [PATCH 1/2] t0006: test timezone parsing

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 6, 2010, 07:01 UTC
Message-ID: <7vpqz13xgw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100704104834.GA23070@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 16 quoted lines

> diff --git a/test-date.c b/test-date.c
> index a9e705f..ac6854a 100644
> --- a/test-date.c
> +++ b/test-date.c
> @@ -21,12 +21,15 @@ static void parse_dates(char **argv, struct timeval *now)
>  	for (; *argv; argv++) {
>  		char result[100];
>  		time_t t;
> +		int tz;
>  
>  		result[0] = 0;
>  		parse_date(*argv, result, sizeof(result));
> -		t = strtoul(result, NULL, 0);
> -		printf("%s -> %s\n", *argv,
> -			t ? show_date(t, 0, DATE_ISO8601) : "bad");
> +		if (sscanf(result, "%ld %d", &t, &tz) == 2)

Gah...

On FreeBSD 8.0, we now see this.

   cc1: warnings being treated as errors
   test-date.c: In function 'parse_dates':
   test-date.c:28: warning: format '%ld' expects type 'long int *', but argument 3 has type 'time_t *'