Re: [PATCH v4 3/8] worktree: refactor infer_backlink return

From: Caleb White <cdwhite3@pm.me>
Date: Nov 22, 2024, 19:26 UTC
Message-ID: <svDK3f3yQtR2snjDN2RJPcvSLOV200EFlIpOhyyk1DfgPI9EYZzH9Um-GcnCcZuwbZ4u5V_khXizC-l1cOX_aahBlCDWPYjpdkYJfr34YBU=@pm.me>
In-Reply-To: <18dd2d59-aa12-4921-bd2a-2bbc0027c63c@gmail.com>

On Friday, November 22nd, 2024 at 10:44, Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 7 quoted lines

> On 20/11/2024 05:20, Caleb White wrote:
> > Originally this function was called inside an `if` statement, however,
> > another topic extracted the call to a separate line and so this return
> > was no longer used. I decided to keep the return anyway in case it was
> > useful in the future.
> 
> If we don't use the return value I'd be inclined to leave it as is.

This is being changed in response to feedback on the previous topic (which was merged a bit too prematurely). I would prefer to leave these changes in if that's alright to respect the previous reviewers and given that I've already made the changes.

Best,

Caleb