Re: [PATCH v4 6/8] worktree: add relative cli/config options to `move` command

From: Caleb White <cdwhite3@pm.me>
Date: Nov 23, 2024, 04:11 UTC
Message-ID: <D5T9IZ3CT3KB.9QNSOHHW7VYL@pm.me>
In-Reply-To: <75b4023a-4005-49ff-a06d-e50fcd1c2b50@gmail.com>

On Fri Nov 22, 2024 at 9:55 AM CST, Phillip Wood wrote:

Show 19 quoted lines

> On 01/11/2024 04:38, Caleb White wrote:
>> [...]
>> +test_expect_success 'move worktree with absolute path to relative path' '
>> +	git config worktree.useRelativePaths false &&
>> +	git worktree add ./absolute &&
>> +	git worktree move --relative-paths absolute relative &&
>> +	cat relative/.git >actual &&
>> +	echo "gitdir: ../.git/worktrees/absolute" >expect &&
>> +	test_cmp expect actual &&
>> +	git config worktree.useRelativePaths true &&
>> +	git worktree move relative relative2 &&
>> +	cat relative2/.git >actual &&
>> +	echo "gitdir: ../.git/worktrees/absolute" >expect &&
>> +	test_cmp expect actual
>> +'
>
> As with the last patch we should use test_config and stop copying files
> just to compare them. It's probably worth checking the gitdir file as
> well as .git here as well.

Updated, thanks for pointing that out.

Best,

Caleb